Introduces the manifold of centered matrices #185
Conversation
…dManifold, modify documentation, add functions check_tangent_vector, embed, manifold_dimension, project and Base.show
…nclude it in runtests.jl
|
I added a test tolerance for manifold points and it seems to fail for fixed rank matrices on Julia 1.4. But it works locally on my Julia 1.4. |
There was a problem hiding this comment.
Thanks for the PR and getting it here. I checked the error we ran into, and actually setting the default atol=1 was not a good (also not for tangent). So I made the few changes as a review here. With the new default I also directly added the values required for centered matrices.
…t/utils.jl to be 0 instead of 1. Co-authored-by: Ronny Bergmann <[email protected]>
Co-authored-by: Ronny Bergmann <[email protected]>
Co-authored-by: Ronny Bergmann <[email protected]>
# Conflicts: # .github/workflows/ci.yml
…itive_definite.jl
…test/groups/special_orthogonal.jl
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
==========================================
+ Coverage 94.30% 94.34% +0.04%
==========================================
Files 50 51 +1
Lines 3211 3234 +23
==========================================
+ Hits 3028 3051 +23
Misses 183 183
Continue to review full report at Codecov.
|
kellertuer
added
the
Ready-for-Review
kellertuer
removed
the
Ready-for-Review
Transfers the manifold of centered matrices from the Matlab package manopt ( see https://www.manopt.org/reference/manopt/manifolds/euclidean/centeredmatrixfactory.html) to Julia.