Simplify project! for Stiefel #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dahong67
changed the title
sethaxen
approved these changes
Apr 8, 2020
kellertuer
approved these changes
Apr 9, 2020
|
Better yet, now master should just work, so merge master in, and if it passes, I'll merge the PR. |
|
Oh nevermind, I see that the CI is running correctly after reopening, it's just that the checks also show the old failed CI because those have different names. Okay, we'll just see if it passes. |
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 96.72% 96.71% -0.01%
==========================================
Files 48 48
Lines 3023 3015 -8
==========================================
- Hits 2924 2916 -8
Misses 99 99
Continue to review full report at Codecov.
|
sethaxen
changed the title
|
Wow, you are quite efficient. Thanks for resolving the testing stuff and merging! :) |
|
Thanks for helping and contributing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do simplifications of
project!method discussed in #141 and mentioned in #142.Key idea is that
s.U' * s.Uin the previous implementation should (up to numerical issues) be approximatelyIin which case the remaining code simplifies.