Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bases for CholeskySpace and LogCholesky metric #780

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

mateuszbaran
Copy link
Member

Some stuff that I needed for Kalman filters.

Also get_parameter_arg should probably go in more places.

@mateuszbaran mateuszbaran added Ready-for-Review A label for pull requests that are feature-ready preview docs Add this label if you want to see a PR-preview of the documentation labels Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (ca9e634) to head (7937238).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage   96.44%   96.45%   +0.01%     
==========================================
  Files         127      127              
  Lines       11843    11890      +47     
==========================================
+ Hits        11422    11469      +47     
  Misses        421      421              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, up to one small comment.

src/manifolds/SymmetricPositiveDefinite.jl Outdated Show resolved Hide resolved
@mateuszbaran
Copy link
Member Author

Can you also check #779 for the 0.10.12 release? It's quite simple.

@mateuszbaran mateuszbaran merged commit 0c2a7b7 into master Jan 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants