minor adaptation of (inverse) retractions

JuliaManifolds · Oct 16, 2023 · d6091f8 · d6091f8
1 parent 17b5a4a
commit d6091f8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 18 deletions.
diff --git a/src/Manifolds.jl b/src/Manifolds.jl
@@ -23,10 +23,8 @@ import ManifoldsBase:
     _access_nested,
     _get_basis,
     _injectivity_radius,
-    _inverse_retract,
     _inverse_retract!,
     _read,
-    _retract,
     _retract!,
     _write,
     active_traits,
@@ -100,7 +98,6 @@ import ManifoldsBase:
     is_vector,
     inverse_retract,
     inverse_retract!,
-    _inverse_retract,
     _inverse_retract!,
     inverse_retract_cayley!,
     inverse_retract_embedded!,

diff --git a/src/manifolds/VectorBundle.jl b/src/manifolds/VectorBundle.jl
@@ -149,10 +149,6 @@ function inner(B::FiberBundle, p, X, Y)
     return inner(B.manifold, px, VXM, VYM) + inner(F, Vx, VXF, VYF)
 end
 
-function _inverse_retract(M::FiberBundle, p, q, ::FiberBundleInverseProductRetraction)
-    return inverse_retract_product(M, p, q)
-end
-
 function _inverse_retract!(M::FiberBundle, X, p, q, ::FiberBundleInverseProductRetraction)
     return inverse_retract_product!(M, X, p, q)
 end
@@ -243,10 +239,6 @@ function project!(B::VectorBundle, Y, p, X)
     return Y
 end
 
-function _retract(M::VectorBundle, p, X, t::Number, ::FiberBundleProductRetraction)
-    return retract_product(M, p, X, t)
-end
-
 function _retract!(M::VectorBundle, q, p, X, t::Number, ::FiberBundleProductRetraction)
     return retract_product!(M, q, p, X, t)
 end

diff --git a/test/manifolds/product_manifold.jl b/test/manifolds/product_manifold.jl
@@ -47,16 +47,15 @@ using RecursiveArrayTools: ArrayPartition
     TEST_STATIC_SIZED && push!(types, MVector{5,Float64})
 
     retraction_methods = [
-        Manifolds.ProductRetraction(
-            ManifoldsBase.ExponentialRetraction(),
-            ManifoldsBase.ExponentialRetraction(),
-        ),
+        ProductRetraction(ExponentialRetraction(), ExponentialRetraction()),
+        ExponentialRetraction(),
     ]
     inverse_retraction_methods = [
-        Manifolds.InverseProductRetraction(
-            ManifoldsBase.LogarithmicInverseRetraction(),
-            ManifoldsBase.LogarithmicInverseRetraction(),
+        InverseProductRetraction(
+            LogarithmicInverseRetraction(),
+            LogarithmicInverseRetraction(),
         ),
+        LogarithmicInverseRetraction(),
     ]
 
     @testset "get_component, set_component!, getindex and setindex!" begin