fixing some issues on Julia 1.7-rc1

JuliaManifolds · Sep 21, 2021 · c723345 · kellertuer · Sep 21, 2021 · mateuszbaran
1 parent cf00e22
commit c723345
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/src/nlsolve.jl b/src/nlsolve.jl
@@ -55,6 +55,7 @@ function _inverse_retract_nlsolve(
         retract!(M, F, p, project(M, p, X), retraction; kwargs...)
         project_point && project!(M, q, q)
         F .-= q
+        project_point && project!(M, F, F)
         return F
     end
     isdefined(Manifolds, :NLsolve) ||

diff --git a/test/groups/special_euclidean.jl b/test/groups/special_euclidean.jl
@@ -78,6 +78,7 @@ Random.seed!(10)
                     X_pts;
                     test_diff=true,
                     diff_convs=[(), (LeftAction(),), (RightAction(),)],
+                    atol=1e-9,
                 )
             end
         end

diff --git a/test/manifolds/rotations.jl b/test/manifolds/rotations.jl
@@ -116,7 +116,7 @@ include("../utils.jl")
                 point_distributions=[ptd],
                 tvector_distributions=[tvd],
                 basis_types_to_from=basis_types,
-                exp_log_atol_multiplier=20,
+                exp_log_atol_multiplier=80,
                 retraction_atol_multiplier=12,
                 test_inplace=true,
             )
-Original file line number
+Diff line change
@@ Expand Up / @@ -78,6 +78,7 @@ Random.seed!(10) @@
                         X_pts;
                         test_diff=true,
                         diff_convs=[(), (LeftAction(),), (RightAction(),)],
+                        atol=1e-9,
                     )
                 end
             end
@@ Expand Down @@