is_flat returns true for Cholesky space and SPD with log-Cholesky met…

…ric.
JuliaManifolds · Nov 13, 2023 · ae8fe22 · ae8fe22
1 parent 5d267d5
commit ae8fe22
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/manifolds/CholeskySpace.jl b/src/manifolds/CholeskySpace.jl
@@ -132,9 +132,9 @@ end
 """
     is_flat(::CholeskySpace)
 
-Return false. [`CholeskySpace`](@ref) is not a flat manifold.
+Return true. [`CholeskySpace`](@ref) is a flat manifold.
 """
-is_flat(M::CholeskySpace) = false
+is_flat(M::CholeskySpace) = true
 
 @doc raw"""
     log(M::CholeskySpace, X, p, q)

diff --git a/src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl b/src/manifolds/SymmetricPositiveDefiniteLogCholesky.jl
@@ -99,10 +99,10 @@ end
 """
     is_flat(::MetricManifold{ℝ,<:SymmetricPositiveDefinite,LogCholeskyMetric})
 
-Return false. [`SymmetricPositiveDefinite`](@ref) with [`LogCholeskyMetric`](@ref)
-is not a flat manifold.
+Return true. [`SymmetricPositiveDefinite`](@ref) with [`LogCholeskyMetric`](@ref)
+is a flat manifold.
 """
-is_flat(M::MetricManifold{ℝ,<:SymmetricPositiveDefinite,LogCholeskyMetric}) = false
+is_flat(M::MetricManifold{ℝ,<:SymmetricPositiveDefinite,LogCholeskyMetric}) = true
 
 @doc raw"""
     log(M::MetricManifold{ℝ,<:SymmetricPositiveDefinite,LogCholeskyMetric}, p, q)