Skip to content

Commit

Permalink
remove deprecations, update NEWS
Browse files Browse the repository at this point in the history
  • Loading branch information
mateuszbaran committed Oct 17, 2023
1 parent 8e97d94 commit 3910dcd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
5 changes: 4 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- Vector bundles are generalized to fiber bundles.
- Vector bundles are generalized to fiber bundles. Old `BundleFibers` functionality was reworked to better match mathematical abstractions. Fiber bundle functionality is experimental and minor changes may happen without a breaking release, with the exception of `TangentBundle` which is considered to be stable.
- `RotationTranslationAction` is introduced.

### Changed
Expand Down Expand Up @@ -97,8 +97,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
```

- Argument order for type aliases `RotationActionOnVector` and `RotationTranslationActionOnVector`: most often dispatched on argument is now first.
- A more consistent handling of action direction was introduced. 4-valued `ActionDirection` was split into 2-valued `ActionDirection` (either left or right action) and `GroupActionSide` (action acting from the left or right side). See [https://github.com/JuliaManifolds/Manifolds.jl/issues/637](https://github.com/JuliaManifolds/Manifolds.jl/issues/637) for a design discussion.

### Removed

- `ProductRepr` is removed; please use `ArrayPartition` instead.
- Default methods throwing "not implemented" `ErrorException` for some group-related operations. Standard `MethodError` is now thrown instead.
- `LinearAffineMetric` was deprecated in a previous release and the symbol is now removed.
Please use `AffineInvariantMetric` instead.
3 changes: 1 addition & 2 deletions src/deprecated.jl
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
Base.@deprecate_binding LinearAffineMetric AffineInvariantMetric
export LinearAffineMetric

5 changes: 1 addition & 4 deletions test/test_deprecated.jl
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
using Manifolds, ManifoldsBase, Test

@testset "Deprecation tests" begin
# Let's just test that for now it still works
@test LinearAffineMetric() === AffineInvariantMetric()
end
@testset "Deprecation tests" begin end

0 comments on commit 3910dcd

Please sign in to comment.