fix allocation on tangent spaces and fixed rank for random point/vect…

…or generation.

src/manifolds/FixedRankMatrices.jl

@@ -127,6 +127,17 @@ function allocate_result(
     # vals are p and X, so we can use their fields to set up those of the UMVTVector
     return UMVTVector(allocate(p.U, m, k), allocate(p.S, k, k), allocate(p.Vt, k, n))
 end
+function allocate_result(::FixedRankMatrices{m,n,k}, ::typeof(rand), p) where {m,n,k}
+    # vals are p and X, so we can use their fields to set up those of the UMVTVector
+    return UMVTVector(allocate(p.U, m, k), allocate(p.S, k, k), allocate(p.Vt, k, n))
+end
+function allocate_result(::FixedRankMatrices{m,n,k}, ::typeof(rand)) where {m,n,k}
+    return SVDMPoint(
+        Matrix{Float64}(undef, m, k),
+        Vector{Float64}(undef, k),
+        Matrix{Float64}(undef, k, n),
+    )
+end
 
 Base.copy(v::UMVTVector) = UMVTVector(copy(v.U), copy(v.M), copy(v.Vt))
 
@@ -448,32 +459,7 @@ and the singular values are sampled uniformly at random.
 If `vector_at` is not `nothing`, generate a random tangent vector in the tangent space of
 the point `vector_at` on the `FixedRankMatrices` manifold `M`.
 """
-function Random.rand(M::FixedRankMatrices; vector_at=nothing, kwargs...)
-    return rand(Random.default_rng(), M; vector_at=vector_at, kwargs...)
-end
-function Random.rand(
-    rng::AbstractRNG,
-    M::FixedRankMatrices{m,n,k};
-    vector_at=nothing,
-    kwargs...,
-) where {m,n,k}
-    if vector_at === nothing
-        p = SVDMPoint(
-            Matrix{Float64}(undef, m, k),
-            Vector{Float64}(undef, k),
-            Matrix{Float64}(undef, k, n),
-        )
-        return rand!(rng, M, p; kwargs...)
-    else
-        X = UMVTVector(
-            Matrix{Float64}(undef, m, k),
-            Matrix{Float64}(undef, k, k),
-            Matrix{Float64}(undef, k, n),
-        )
-        return rand!(rng, M, X; vector_at, kwargs...)
-    end
-end
-
+Random.rand(M::FixedRankMatrices; vector_at=nothing, kwargs...)
 function Random.rand!(
     rng::AbstractRNG,
     ::FixedRankMatrices{m,n,k},

src/manifolds/VectorBundle.jl

@@ -292,6 +292,10 @@ See also [`VectorBundleInverseProductRetraction`](@ref).
 """
 struct VectorBundleProductRetraction <: AbstractRetractionMethod end
 
+function allocate_result(M::TangentSpaceAtPoint, ::typeof(rand))
+    return zero_vector(M.fiber.manifold, M.point)
+end
+
 base_manifold(B::VectorBundleFibers) = base_manifold(B.manifold)
 base_manifold(B::VectorSpaceAtPoint) = base_manifold(B.fiber)
 base_manifold(B::VectorBundle) = base_manifold(B.manifold)