Skip to content

Implement translate_diff and inv_diff for all groups (#679) #3089

Implement translate_diff and inv_diff for all groups (#679)

Implement translate_diff and inv_diff for all groups (#679) #3089

Triggered via pull request November 13, 2023 17:57
Status Failure
Total duration 1m 34s
Artifacts

format.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 10 warnings
Format Check
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
Format Check
Process completed with exit code 1.
Format Check: src/groups/addition_operation.jl#L166
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/groups/addition_operation.jl:166:-
Format Check: src/groups/circle_group.jl#L93
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/groups/circle_group.jl:93:-translate_diff(::CircleGroup, ::Identity{MultiplicationOperation}, q, X, ::LeftForwardAction) = X src/groups/circle_group.jl:94:-translate_diff(::CircleGroup, ::Identity{MultiplicationOperation}, q, X, ::RightForwardAction) = X src/groups/circle_group.jl:95:-translate_diff(::CircleGroup, ::Identity{MultiplicationOperation}, q, X, ::LeftBackwardAction) = X src/groups/circle_group.jl:96:-translate_diff(::CircleGroup, ::Identity{MultiplicationOperation}, q, X, ::RightBackwardAction) = X src/groups/circle_group.jl:93:+function translate_diff( src/groups/circle_group.jl:94:+ ::CircleGroup, src/groups/circle_group.jl:95:+ ::Identity{MultiplicationOperation}, src/groups/circle_group.jl:96:+ q, src/groups/circle_group.jl:97:+ X, src/groups/circle_group.jl:98:+ ::LeftForwardAction, src/groups/circle_group.jl:99:+) src/groups/circle_group.jl:100:+ return X src/groups/circle_group.jl:101:+end src/groups/circle_group.jl:102:+function translate_diff( src/groups/circle_group.jl:103:+ ::CircleGroup, src/groups/circle_group.jl:104:+ ::Identity{MultiplicationOperation}, src/groups/circle_group.jl:105:+ q, src/groups/circle_group.jl:106:+ X, src/groups/circle_group.jl:107:+ ::RightForwardAction, src/groups/circle_group.jl:108:+) src/groups/circle_group.jl:109:+ return X src/groups/circle_group.jl:110:+end src/groups/circle_group.jl:111:+function translate_diff( src/groups/circle_group.jl:112:+ ::CircleGroup, src/groups/circle_group.jl:113:+ ::Identity{MultiplicationOperation}, src/groups/circle_group.jl:114:+ q, src/groups/circle_group.jl:115:+ X, src/groups/circle_group.jl:116:+ ::LeftBackwardAction, src/groups/circle_group.jl:117:+) src/groups/circle_group.jl:118:+ return X src/groups/circle_group.jl:119:+end src/groups/circle_group.jl:120:+function translate_diff( src/groups/circle_group.jl:121:+ ::CircleGroup, src/groups/circle_group.jl:122:+ ::Identity{MultiplicationOperation}, src/groups/circle_group.jl:123:+ q, src/groups/circle_group.jl:124:+ X, src/groups/circle_group.jl:125:+ ::RightBackwardAction, src/groups/circle_group.jl:126:+) src/groups/circle_group.jl:127:+ return X src/groups/circle_group.jl:128:+end
Format Check: src/groups/circle_group.jl#L99
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/groups/circle_group.jl:99:-translate_diff!(G::CircleGroup, Y, p, q, X, conv::LeftForwardAction) = _common_translate_diff!(G, Y, p, q, X, conv) src/groups/circle_group.jl:100:-translate_diff!(G::CircleGroup, Y, p, q, X, conv::RightForwardAction) = _common_translate_diff!(G, Y, p, q, X, conv) src/groups/circle_group.jl:101:-translate_diff!(G::CircleGroup, Y, p, q, X, conv::LeftBackwardAction) = _common_translate_diff!(G, Y, p, q, X, conv) src/groups/circle_group.jl:102:-translate_diff!(G::CircleGroup, Y, p, q, X, conv::RightBackwardAction) = _common_translate_diff!(G, Y, p, q, X, conv) src/groups/circle_group.jl:131:+function translate_diff!(G::CircleGroup, Y, p, q, X, conv::LeftForwardAction) src/groups/circle_group.jl:132:+ return _common_translate_diff!(G, Y, p, q, X, conv) src/groups/circle_group.jl:133:+end src/groups/circle_group.jl:134:+function translate_diff!(G::CircleGroup, Y, p, q, X, conv::RightForwardAction) src/groups/circle_group.jl:135:+ return _common_translate_diff!(G, Y, p, q, X, conv) src/groups/circle_group.jl:136:+end src/groups/circle_group.jl:137:+function translate_diff!(G::CircleGroup, Y, p, q, X, conv::LeftBackwardAction) src/groups/circle_group.jl:138:+ return _common_translate_diff!(G, Y, p, q, X, conv) src/groups/circle_group.jl:139:+end src/groups/circle_group.jl:140:+function translate_diff!(G::CircleGroup, Y, p, q, X, conv::RightBackwardAction) src/groups/circle_group.jl:141:+ return _common_translate_diff!(G, Y, p, q, X, conv) src/groups/circle_group.jl:142:+end
Format Check: src/groups/general_linear.jl#L281
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/groups/general_linear.jl:281:- src/groups/general_linear.jl:282:-
Format Check: src/groups/general_unitary_groups.jl#L299
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/groups/general_unitary_groups.jl:299:-function adjoint_action!( src/groups/general_unitary_groups.jl:300:- G::GeneralUnitaryMultiplicationGroup, src/groups/general_unitary_groups.jl:301:- Y, src/groups/general_unitary_groups.jl:302:- p, src/groups/general_unitary_groups.jl:303:- X, src/groups/general_unitary_groups.jl:304:- ::LeftAction src/groups/general_unitary_groups.jl:305:-) src/groups/general_unitary_groups.jl:299:+function adjoint_action!(G::GeneralUnitaryMultiplicationGroup, Y, p, X, ::LeftAction)
Format Check: src/groups/general_unitary_groups.jl#L309
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/groups/general_unitary_groups.jl:309:-function adjoint_action!( src/groups/general_unitary_groups.jl:310:- G::GeneralUnitaryMultiplicationGroup, src/groups/general_unitary_groups.jl:311:- Y, src/groups/general_unitary_groups.jl:312:- p, src/groups/general_unitary_groups.jl:313:- X, src/groups/general_unitary_groups.jl:314:- ::RightAction, src/groups/general_unitary_groups.jl:315:-) src/groups/general_unitary_groups.jl:303:+function adjoint_action!(G::GeneralUnitaryMultiplicationGroup, Y, p, X, ::RightAction)
Format Check: src/groups/group.jl#L449
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/groups/group.jl:449:-function adjoint_action(::TraitList{<:IsGroupManifold}, G::AbstractDecoratorManifold, p, Xₑ, dir) src/groups/group.jl:449:+function adjoint_action( src/groups/group.jl:450:+ ::TraitList{<:IsGroupManifold}, src/groups/group.jl:451:+ G::AbstractDecoratorManifold, src/groups/group.jl:452:+ p, src/groups/group.jl:453:+ Xₑ, src/groups/group.jl:454:+ dir, src/groups/group.jl:455:+)
Format Check: src/groups/group.jl#L455
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/groups/group.jl:455:-adjoint_action!(G::AbstractDecoratorManifold, Y, p, X) = adjoint_action!(G, Y, p, X, LeftAction()) src/groups/group.jl:461:+function adjoint_action!(G::AbstractDecoratorManifold, Y, p, X) src/groups/group.jl:462:+ return adjoint_action!(G, Y, p, X, LeftAction()) src/groups/group.jl:463:+end
Format Check: src/groups/group.jl#L457
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/groups/group.jl:457:-adjoint_action!(G::AbstractDecoratorManifold, Y, p, X, ::RightAction) = adjoint_action!(G, Y, inv(G, p), X, LeftAction()) src/groups/group.jl:465:+function adjoint_action!(G::AbstractDecoratorManifold, Y, p, X, ::RightAction) src/groups/group.jl:466:+ return adjoint_action!(G, Y, inv(G, p), X, LeftAction()) src/groups/group.jl:467:+end
Format Check: src/groups/group.jl#L564
[JuliaFormatter] reported by reviewdog 🐶 Raw Output: src/groups/group.jl:564:-inv_diff!(::TraitList{<:IsGroupManifold}, G::AbstractDecoratorManifold, Y, p, X) = -adjoint_action!(G, Y, p, X) src/groups/group.jl:574:+function inv_diff!(::TraitList{<:IsGroupManifold}, G::AbstractDecoratorManifold, Y, p, X) src/groups/group.jl:575:+ return -adjoint_action!(G, Y, p, X) src/groups/group.jl:576:+end