Jacobians #47
Merged
Jacobians #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this looks good to me in general, the tests are currently failing. Also great that you directly provided a very general allocation for the Jacobian. |
|
The ManifoldsBase.jl PR should fix the CI failure. What do you think about naming the basis argument for the Jacobian? Maybe |
I must have missed that naming, yes I think your new proposals fit petter into Manopt and I would prefer them. |
mateuszbaran
added
the
preview docs
kellertuer
reviewed
Nov 12, 2024
kellertuer
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added Jacobians of
expandlogas a step forward towards full support of robotics stuff. What do you think about this approach?The tests compare results against a finite difference computation on a sphere.