-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Special) Orthogonal / Unitary / Euclidean groups #17
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
- Coverage 99.20% 98.53% -0.67%
==========================================
Files 13 19 +6
Lines 756 1095 +339
==========================================
+ Hits 750 1079 +329
- Misses 6 16 +10 ☔ View full report in Codecov by Sentry. |
Status update 1: In theory SE(n) is defined, in practice I am not able to dispatch on the new const. Hence the constructor still falls back to calling the general show (of semidirect product) @mateuszbaran can you maybe take a look? After an hour of trying I am a bit out of ideas what is wrong with my constant |
I've fixed the issue with SpecialEuclideanGroup alias 🙂 |
Nice. I would not have noticed the tuple necessary during the rest of the year. You changed one . to a map. Should I do that for the rest as well? |
Oh and sorry for the capitalisation foo – Mac OS does not distinguish that on files when loading them … super annoying. |
I generally prefer
No problem, that was an easy fix 🙂 |
…eGroups.jl into kellertuer/SOn-and-SEn
The main work today was a bit of structure, since now one of my main worries already works – So I am confident that this should not be too complicated – and am quite happy with how semidirect turned out. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…eGroups.jl into kellertuer/SOn-and-SEn
All dummies are there, now the rest is mainly getting all functions from the test suite implemented and tested. |
…ally needed. Starts transferring xp/log from Manifolds.jl for these.
…as what made the last tests fail.,
…eGroups.jl into kellertuer/SOn-and-SEn
…red due to numerical imprecision.
11be112
to
cfc9670
Compare
…eGroups.jl into kellertuer/SOn-and-SEn
# Conflicts: # Project.toml # src/LieGroups.jl # src/group_operations/multiplication_operation.jl # src/groups/power_group.jl # src/groups/product_group.jl # test/LieGroupsTestSuite.jl/LieGroupsTestSuite.jl # test/runtests.jl
This PR aims to provide the special orthogonal group and the first concrete semidirect product: Special Euclidean, since the complex case is similar, this will also cover the special unitary case.
🛣️🗺️
OrthogonalGroup
SpecialOrthogonalGroup
SpecialEuclideanGroup
UnitrayGroup
SpecialUnitaryGroup