Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Kahan #65

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Add tests for Kahan #65

merged 2 commits into from
Oct 25, 2022

Conversation

JeffFessler
Copy link
Member

Working towards improving code coverage...

@JeffFessler JeffFessler marked this pull request as draft October 24, 2022 14:46
@coveralls
Copy link

coveralls commented Oct 24, 2022

Pull Request Test Coverage Report for Build 3313695501

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.5%) to 92.627%

Totals Coverage Status
Change from base Build 3313520027: 5.5%
Covered Lines: 201
Relevant Lines: 217

💛 - Coveralls

@JeffFessler JeffFessler marked this pull request as ready for review October 24, 2022 14:54
@JeffFessler
Copy link
Member Author

@ivanslapnicar any comments?
And are there any other tests that would be useful to verify correctness?

@ivanslapnicar
Copy link
Contributor

@JeffFessler, all changes are fine. The package is now very nice and complete.

@JeffFessler JeffFessler merged commit 243dc4c into master Oct 25, 2022
@JeffFessler JeffFessler deleted the kahan branch October 25, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants