Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Riemann doctest #59

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Fix Riemann doctest #59

merged 1 commit into from
Oct 23, 2022

Conversation

JeffFessler
Copy link
Member

The doctest for riemann was failing due to an x that should have been a \times.
This fixes that. And I tweaked the citations and docs while in there.
Another purpose of this is to see if the docs will build.
No changes to actual code, so no version bump.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3307533765

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.4%) to 78.972%

Files with Coverage Reduction New Missed Lines %
src/frobenius.jl 3 80.77%
Totals Coverage Status
Change from base Build 3264654829: -1.4%
Covered Lines: 169
Relevant Lines: 214

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Base: 80.37% // Head: 78.97% // Decreases project coverage by -1.40% ⚠️

Coverage data is based on head (b142768) compared to base (a4e72da).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   80.37%   78.97%   -1.41%     
==========================================
  Files           8        8              
  Lines         214      214              
==========================================
- Hits          172      169       -3     
- Misses         42       45       +3     
Impacted Files Coverage Δ
src/riemann.jl 100.00% <ø> (ø)
src/frobenius.jl 80.76% <0.00%> (-11.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JeffFessler
Copy link
Member Author

Normally I would want another pair of eyes on any code changes, but since this is just minor doc tweaks I am going to merge. Hopefully the docs dev badge will work!

@JeffFessler JeffFessler merged commit 14ce178 into master Oct 23, 2022
@JeffFessler JeffFessler deleted the jf/riemann-doc branch October 23, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants