Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions to v3 to use node.js v16 and master branch #58

Merged
merged 3 commits into from
Oct 23, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Oct 20, 2022

Let's also see if the documentation builds correctly in this PR

Let's also see if the documentation builds correctly in this PR
@coveralls
Copy link

coveralls commented Oct 20, 2022

Pull Request Test Coverage Report for Build 3307675532

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 79.907%

Files with Coverage Reduction New Missed Lines %
src/strang.jl 1 69.23%
Totals Coverage Status
Change from base Build 3264654829: -0.5%
Covered Lines: 171
Relevant Lines: 214

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 80.37% // Head: 79.90% // Decreases project coverage by -0.46% ⚠️

Coverage data is based on head (169469e) compared to base (a4e72da).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   80.37%   79.90%   -0.47%     
==========================================
  Files           8        8              
  Lines         214      214              
==========================================
- Hits          172      171       -1     
- Misses         42       43       +1     
Impacted Files Coverage Δ
src/strang.jl 69.23% <0.00%> (-7.70%) ⬇️
src/riemann.jl 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub
Copy link
Member Author

jishnub commented Oct 20, 2022

OK, can replicate the git fetch failure

@jishnub jishnub changed the title Update actions to use node.jl v16 Update actions to v3 to use node.js v16 Oct 20, 2022
@jishnub jishnub closed this Oct 22, 2022
@jishnub jishnub reopened this Oct 22, 2022
This saves CO2 by preventing readme changes from rebuilding docs.
This is probably why docs did not deploy.  Doh!
@JeffFessler JeffFessler changed the title Update actions to v3 to use node.js v16 Update actions to v3 to use node.js v16 and master branch Oct 23, 2022
@JeffFessler
Copy link
Member

With the fix in #61 I am pretty optimistic this will work now.
I am going to go ahead and merge this and see. It is easy to refine later if needed (e.g., using latest).

@JeffFessler JeffFessler merged commit d620db0 into master Oct 23, 2022
@JeffFessler
Copy link
Member

It worked! At last we have docs-dev badge active.
@jishnub please delete the branch if you are satisfied with what was merged,
and please comment on the latest if/when you can. Thanks!

@jishnub jishnub deleted the jishnub-patch-1 branch October 23, 2022 18:27
@jishnub
Copy link
Member Author

jishnub commented Oct 23, 2022

Tbh I don't know enough about GitHub actions as well. Let's use latest for now if it is working. It's unlikely that we use features that live on the bleeding edge, so latest should be equivalent to stable releases.

@JeffFessler
Copy link
Member

OK, I'm testing it in a separate PR #62. Thanks!

@JeffFessler
Copy link
Member

For the record, one can use cache@main if you want live on the bleeding edge:
https://github.com/orgs/community/discussions/37052
Maybe sticking with the tagged version @v3 is safer...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants