Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CompatHelper.yml to v3 #56

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Update CompatHelper.yml to v3 #56

merged 1 commit into from
Oct 17, 2022

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Oct 16, 2022

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3259133032

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.07%) to 77.103%
Files with Coverage Reduction New Missed Lines %
src/strang.jl 1 61.54%
src/companion.jl 5 85.42%
Totals Coverage Status
Change from base Build 2812812154: -1.07%
Covered Lines: 165
Relevant Lines: 214
💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 78.17% // Head: 77.10% // Decreases project coverage by -1.06% ⚠️

Coverage data is based on head (31b644b) compared to base (8ad0f4f).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   78.17%   77.10%   -1.07%     
==========================================
  Files           8        8              
  Lines         197      214      +17     
==========================================
+ Hits          154      165      +11     
- Misses         43       49       +6
Impacted Files Coverage Δ
src/companion.jl 85.41% <0.00%> (-9.94%) ⬇️
src/strang.jl 61.53% <0.00%> (-7.70%) ⬇️
src/vandermonde.jl 100.00% <0.00%> (ø)
src/frobenius.jl 92.30% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub
Copy link
Member Author

jishnub commented Oct 16, 2022

I'm unsure why the documentation build fails to fetch the git repo

@JeffFessler
Copy link
Member

Thanks for the PR. I didn't realize that the recommended workflow has gotten so much longer:
https://github.com/JuliaRegistries/CompatHelper.jl/blob/master/.github/workflows/CompatHelper.yml
It looks like the DOCUMENTER_KEY is outdated. I will try to fix that and then rerun the CI here.

@JeffFessler
Copy link
Member

Actually I do not seem to have permission to update the key.
I can merge PRs but not manage the security.
@jishnub you seem to be a maintainer at the organization level here.
Can you update the security keys for this package?

@jishnub
Copy link
Member Author

jishnub commented Oct 17, 2022

I don't have access to them either. Perhaps only the repo owner does.

@JeffFessler
Copy link
Member

@ivanslapnicar I believe you are the owner of this repo, right?
Can you update the documenter key please? There are instructions here:
https://juliadocs.github.io/Documenter.jl/stable/man/hosting/#Hosting-Documentation
To do this you need to go under "Settings."
Depending on your browser window size, you might not see the settings tab. If you don't see it, then look for the "..." tab in the top right and it will be under that.

@JeffFessler
Copy link
Member

@jishnub meanwhile I will go ahead and merge this PR. Getting documenter to work again can be a separate issue.

@JeffFessler JeffFessler merged commit a4e72da into master Oct 17, 2022
@JeffFessler JeffFessler deleted the jishnub-patch-1-2 branch October 17, 2022 11:16
@ivanslapnicar
Copy link
Contributor

@JeffFessler, which "Settings" are you referring to?

@JeffFessler
Copy link
Member

We refer to the Settings for the SpecialMatrices package that you own (I think).
It's the tab with the gear icon on the upper right if your window is wide enough:

Screen Shot 2022-10-17 at 9 00 44 PM

Under that tab is a "Security" section that has "Deploy keys" and "Secrets/actions" that apparently need updating (or installed, I can't tell) based on the CI logs.

@ivanslapnicar
Copy link
Contributor

I don't have the Settings button. Does this mean that I might not be an owner anymore?
What do you suggest doing?

Screenshot 2022-10-18 at 17-23-25 JuliaMatrices_SpecialMatrices jl Julia package for working with special matrix types

@JeffFessler JeffFessler mentioned this pull request Oct 18, 2022
Closed
@JeffFessler
Copy link
Member

oh! then you are the same situation as i am! we need to find the owner then!
@dlfivefifty are you an owner of this package? if so, can you set up DOCUMENTER_KEY for it? if not, can you help us find the owner?
i thought everyone at the org level would be an owner, but @jishnub is there at org level but says he is not an owner. somehow it should be more transparent who is the owner so that issues can be addressed the right person!

@JeffFessler
Copy link
Member

BTW, I have a "Settings" button for this repo, but under that button I do not have access to the ssh keys, whereas for repos that I own I can set/delete/update those keys.

@JeffFessler
Copy link
Member

Screen Shot 2022-10-18 at 11 59 20 AM

@ivanslapnicar
Copy link
Contributor

ivanslapnicar commented Oct 18, 2022 via email

@jishnub
Copy link
Member Author

jishnub commented Oct 18, 2022

I think anyone who is a member of the organization can merge PRs, so that might not reveal the owner

@JeffFessler
Copy link
Member

@ivanslapnicar there are already a few PRs in the queue. none of them should be merged (they all need work) but you can see if you have the "squash and merge" button available on on the non-draft ones. i'm pretty sure you will, like i do.

@JeffFessler
Copy link
Member

I checked and I am an "outside collaborator on 1 repository" for JuliaMatrices.
@ivanslapnicar you can try this link to check your status:
https://github.com/settings/organizations

@ivanslapnicar
Copy link
Contributor

ivanslapnicar commented Oct 18, 2022 via email

@ivanslapnicar
Copy link
Contributor

ivanslapnicar commented Oct 18, 2022 via email

@jishnub
Copy link
Member Author

jishnub commented Oct 18, 2022

I think "outside collaborator on 1 repository" implies that one is a member of a repo while not being a member of the organization that the repo belongs to.

@JeffFessler
Copy link
Member

@dkarrasch Are you an owner of this package? If so, can you set up DOCUMENTER_KEY for it?
If not, can you help us find the owner? I thought everyone at the org level would be an owner, but it seems not because @jishnub is there at org level but says he is not an owner. How do we figure out who has access to the ssh key setup?

@jishnub
Copy link
Member Author

jishnub commented Oct 20, 2022

Incidentally, are we sure that DOCUMENTER_KEY is the issue? When I look at previous Documenter runs at https://github.com/JuliaMatrices/SpecialMatrices.jl/actions/workflows/Documentation.yml, I see that there was a successful run 3 months back. Assuming that the secrets haven't changed in a few months, the variable should be properly set up, and the error message suggestion may not be the real cause.

@dkarrasch
Copy link
Member

@JeffFessler I don't even have a settings button, but merge rights.

@ararslan
Copy link
Member

There was a DOCUMENTER_KEY repository secret but no associated deploy key. I've updated both. I'll also update folks' permissions to increase the bus factor here.

@ivanslapnicar
Copy link
Contributor

ivanslapnicar commented Oct 20, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jishnub @coveralls @JeffFessler @ivanslapnicar @dkarrasch @ararslan