Add polar decompositions #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change imports updated versions of the polar decomposition routines originally implemented by Weijian Zhang (https://github.com/weijianzhang/PolarFact.jl).
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 90.00% 91.18% +1.18%
==========================================
Files 5 6 +1
Lines 490 669 +179
==========================================
+ Hits 441 610 +169
- Misses 49 59 +10
Continue to review full report at Codecov.
|
dlfivefifty
requested changes
Nov 12, 2020
|
Can you get the coverage up? |
Until they can do better than "an error occurred while generating the build script".
|
Why is OS X allowed to fail? |
|
I suppressed OSX because I encountered infrastructure failures like this one unrelated to the package; the alternative is to ask you to manually restart the checks until they find a lucky instance. |
dlfivefifty
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change imports updated versions of the polar decomposition routines
originally implemented by Weijian Zhang (https://github.com/weijianzhang/PolarFact.jl).