Use the truncated QR LAPACK routine geqp3rk as the backend for the partial qr factorization. fixes #60 #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LAPACK routine
geqpr3k
available starting in v3.12.0 computes the truncated QR factorization based on one of three stopping conditions. This PR adds a backend forpqr
that uses the LAPACK routine instead of the Julia native backend in the functiongeqp3_adap_main!
. This backend is faster than using the current implementation.There is still one unresolved issue that I need help with. When a max rank to truncate at is not provided, the
R
factor from the lapack backend differs from the current version and I am not sure why. Fixes #60