-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EmbeddedMap
#174
Add EmbeddedMap
#174
Conversation
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
- Coverage 99.65% 98.40% -1.25%
==========================================
Files 14 15 +1
Lines 1151 1193 +42
==========================================
+ Hits 1147 1174 +27
- Misses 4 19 +15
Continue to review full report at Codecov.
|
a589c1a
to
9e99938
Compare
If I'm not mistaken, then this PR coincides greatly with |
Another thing: if one ignores the monotonic indices test, then this allows for lazy |
@krcools What do you think: I'm finding the name |
I am using LiftedMaps in my own registered projects and will keep doing so. Functionality is indeed similar; a noteworthy difference is that LiftedMaps tries to be compatible with non-traditional axes (such as the blocked axes from BlockArrays). I guess if the name is not exported both implementations can happily coexist. Alternative names? Perhaps |
Thanks for your feedback @krcools! Yes, we have avoided the dependency on BlockArrays.jl when we added the |
Co-authored-by: Jeff Fessler <[email protected]>
This is a rebase of #65. Closes #65.
Dropping the requirement of monotonically increasing indices would allow to define "lazy" reversed maps, though negative strides in BLAS.gemv! is allowed starting from v1.8 only.
I wonder if
IndexMap
is the best name for it, though. "Index" is fairly generic, so we may want to spend some brain power to come up with a better name.