Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow wrapping of vectors, extend Kronecker product #136

Merged
merged 7 commits into from
Mar 24, 2021

Conversation

dkarrasch
Copy link
Member

This treats vectors upon wrapping in LinearMap like a column matrix, without reshaping however. This allows to easily represent rank-1 operators as v ⊗ w' with optimal performance.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #136 (6cfda4f) into master (209d6e2) will increase coverage by 0.00%.
The diff coverage is 97.43%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   99.80%   99.80%           
=======================================
  Files          14       14           
  Lines        1037     1042    +5     
=======================================
+ Hits         1035     1040    +5     
  Misses          2        2           
Impacted Files Coverage Δ
src/LinearMaps.jl 97.67% <83.33%> (ø)
src/blockmap.jl 100.00% <100.00%> (ø)
src/conversion.jl 100.00% <100.00%> (ø)
src/kronecker.jl 100.00% <100.00%> (ø)
src/show.jl 100.00% <100.00%> (ø)
src/wrappedmap.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209d6e2...6cfda4f. Read the comment docs.

@dkarrasch dkarrasch force-pushed the dk/vectorkronecker branch 2 times, most recently from 989dd10 to d56bed2 Compare March 10, 2021 14:07
@dkarrasch dkarrasch force-pushed the dk/vectorkronecker branch from cfa1474 to 560807a Compare March 17, 2021 09:26
@dkarrasch
Copy link
Member Author

Are there any objections against starting to treat vectors as column matrices in LinearMaps constructors? If not, I think this is a nice generalization, and there was a request for that in the Slack channel for lazy outer products.

@Jutho
Copy link
Collaborator

Jutho commented Mar 24, 2021

I guess that is indeed fine; I see no obstructions.

@dkarrasch dkarrasch merged commit 032832e into master Mar 24, 2021
@dkarrasch dkarrasch deleted the dk/vectorkronecker branch March 24, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants