-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci.yml #135
Update ci.yml #135
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 95.04% 94.81% -0.24%
==========================================
Files 11 11
Lines 1636 1640 +4
==========================================
Hits 1555 1555
- Misses 81 85 +4 ☔ View full report in Codecov by Sentry. |
There are many of the changes here I don't understand. I hadn't realized that I can see that the Update: can see that you are working on fixing the test failures. |
I just copied CI from another repository (I think FillArrays.jl) which @jishnub made changes to... I can revert the ci.yml and just add a test for For reasons that are beyond my comprehension the tests on ubuntu/macos are using test files from a different branch which makes no sense to me so maybe reverting the CI will avoid this issue... |
Oh sorry! I didn't see that you merged the other PR. That's why the tests are failing |
I think we can ignore the codecov failure since it relates to 1.6 specific code |
Thanks for the fixes |
No description provided.