Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml #135

Merged
merged 8 commits into from
Aug 10, 2024
Merged

Update ci.yml #135

merged 8 commits into from
Aug 10, 2024

Conversation

dlfivefifty
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.81%. Comparing base (81eee0d) to head (60a1a9a).

Files Patch % Lines
src/eigenGeneral.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
- Coverage   95.04%   94.81%   -0.24%     
==========================================
  Files          11       11              
  Lines        1636     1640       +4     
==========================================
  Hits         1555     1555              
- Misses         81       85       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasnoack
Copy link
Member

andreasnoack commented Aug 10, 2024

There are many of the changes here I don't understand. I hadn't realized that lts had been disabled in #85 but, except for that one, why are the changes needed? It's deliberate that I don't test on Mac and Windows since there are no binary dependencies so it doesn't seem worth the extra CI time.

I can see that the lts tests actually reveal some issues. Current master seems to rely on some methods in Julia that don't exist in Julia 1.6.

Update: can see that you are working on fixing the test failures.

@dlfivefifty
Copy link
Member Author

I just copied CI from another repository (I think FillArrays.jl) which @jishnub made changes to...

I can revert the ci.yml and just add a test for lts.

For reasons that are beyond my comprehension the tests on ubuntu/macos are using test files from a different branch which makes no sense to me so maybe reverting the CI will avoid this issue...

@dlfivefifty
Copy link
Member Author

Oh sorry! I didn't see that you merged the other PR. That's why the tests are failing

@dlfivefifty
Copy link
Member Author

I think we can ignore the codecov failure since it relates to 1.6 specific code

@andreasnoack andreasnoack merged commit 304c2e5 into master Aug 10, 2024
5 of 7 checks passed
@andreasnoack
Copy link
Member

Thanks for the fixes

@andreasnoack andreasnoack deleted the dl/ci branch August 10, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants