Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mat * vec with non-commutative numbers #413

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 6, 2023

This now matches LinearAlgebra's convention of A * B * alpha + C * beta, from the current alpha * A * B + beta * C.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e445b49) 89.55% compared to head (804a937) 89.55%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files          25       25           
  Lines        3542     3544    +2     
=======================================
+ Hits         3172     3174    +2     
  Misses        370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 592b73f into JuliaLinearAlgebra:master Dec 7, 2023
16 checks passed
@jishnub jishnub deleted the matmul branch December 7, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant