Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rmul Diagonal specialization #319

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Feb 15, 2023

Now that A .* v' is fast, specializing A * D is largely unnecessary. The performance would be improved further by JuliaLinearAlgebra/ArrayLayouts.jl#118.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 82.08% // Head: 82.04% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (0fb1a58) compared to base (bcedda1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   82.08%   82.04%   -0.05%     
==========================================
  Files          24       24              
  Lines        3321     3313       -8     
==========================================
- Hits         2726     2718       -8     
  Misses        595      595              
Impacted Files Coverage Δ
src/generic/broadcast.jl 95.27% <ø> (-0.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub merged commit d0e7a16 into JuliaLinearAlgebra:master Feb 19, 2023
@jishnub jishnub deleted the removediagrmul branch February 19, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant