Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast numbers over vec(data) #304

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jan 31, 2023

On master

julia> B = BandedMatrix(1=>Float64.(1:3000));

julia> @btime $B .* 2;
  8.533 μs (3 allocations: 23.59 KiB)

This PR

julia> @btime $B .* 2;
  2.560 μs (7 allocations: 23.77 KiB)

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 80.55% // Head: 80.58% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (6bd74a8) compared to base (9a573b1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   80.55%   80.58%   +0.03%     
==========================================
  Files          23       23              
  Lines        3270     3276       +6     
==========================================
+ Hits         2634     2640       +6     
  Misses        636      636              
Impacted Files Coverage Δ
src/generic/broadcast.jl 90.04% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dlfivefifty dlfivefifty merged commit c2b319e into JuliaLinearAlgebra:master Feb 7, 2023
@jishnub jishnub deleted the vecbroadcastnumber branch February 7, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants