Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Julia master #258

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Conversation

devmotion
Copy link
Contributor

In JuliaLang/julia#44360, BLAS.libblas and LAPACK.liblapack were removed. Thus BandedMatrices does not work with Julia nightlies currently, which causes test errors e.g. in PDMats (see e.g. https://github.com/JuliaStats/PDMats.jl/runs/6696362323?check_suite_focus=true).

JuliaLang/julia#44379 added Base.libblas_name and Base.liblapack_name which can be used instead (see FluxML/NNlib.jl#396 and FluxML/NNlib.jl#396 (comment)).

@dlfivefifty
Copy link
Member

Please don't test on nightly, it's too unreliable

@devmotion
Copy link
Contributor Author

Sure, I'll revert the commit. I thought it would be good to show at least once though in this PR that the PR actually fixes the issues with Julia nightly that show up in downstream packages.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #258 (4ac9e37) into master (00fe1eb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   75.74%   75.74%           
=======================================
  Files          23       23           
  Lines        3228     3228           
=======================================
  Hits         2445     2445           
  Misses        783      783           
Impacted Files Coverage Δ
src/BandedMatrices.jl 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00fe1eb...4ac9e37. Read the comment docs.

@devmotion
Copy link
Contributor Author

I reverted the last commit (the test errors on nightly are different from the downstream issues that the PR is supposed to fix).

@devmotion
Copy link
Contributor Author

Bump 🙂

@dlfivefifty dlfivefifty merged commit 0e4dd06 into JuliaLinearAlgebra:master Jun 16, 2022
@devmotion devmotion deleted the dw/fix_nightly branch June 16, 2022 12:24
@devmotion
Copy link
Contributor Author

Thanks for merging and releasing this PR! As intended it fixed the downstream CI issues in PDMats: https://github.com/JuliaStats/PDMats.jl/actions/runs/2455339091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants