Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JuliaCon video styles #848

Merged
merged 1 commit into from
May 29, 2020
Merged

Refactor JuliaCon video styles #848

merged 1 commit into from
May 29, 2020

Conversation

zlatanvasovic
Copy link
Contributor

Addresses "make the youtube video link smaller (see GO front page)" from #800 and cleans the CSS up.

Screenshot from 2020-05-29 16-20-08
->
Screenshot from 2020-05-29 16-19-57

@ViralBShah
Copy link
Member

Looks good.

@ViralBShah
Copy link
Member

ViralBShah commented May 29, 2020

Is this still going to pick a random video from that list and show? It looks like it but just making sure.

@zlatanvasovic
Copy link
Contributor Author

@ViralBShah Yes, there should be no issues about that. The JavaScript code is untouched.

@ViralBShah ViralBShah merged commit 15cfb4e into JuliaLang:master May 29, 2020
@zlatanvasovic zlatanvasovic deleted the youtube branch May 29, 2020 16:36
@abhishalya
Copy link
Contributor

No, this does not work properly on mobile devices.

@ViralBShah
Copy link
Member

@zdroid Perhaps revert or fix?

@zlatanvasovic
Copy link
Contributor Author

A fix is incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants