Drop JuliaCon container #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did we drop this? We get a huge amount of video views from this. Most of the juliacon video views come from here. |
|
Let's revert this. For major changes it would be good to let the PRs be open some time to gather feedback. |
|
sorry for the over-enthusiastic merge, I'll bring it back |
|
@ViralBShah Right, I agree. I thought it's not really that prominent since it's not on the top of the page. I'll try to find another way for that section to be redesigned. |
|
~ 33% of all our youtube traffic comes from external sources and ~40% of those external sources are the website. |
|
Thank you. There was a PR that tried to load the video async. |
tlienart
added a commit
that referenced
this pull request
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that golang has video display on its frontpage, but it's not really that appealing. I doubt anyone comes to the frontpage to see the videos, and if you actually want to see them, you're better off opening them in the new tab. Also, embedding YouTube videos slows down the page load substantially.
Source: #800 (comment)