Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nightly channels rebased #384

Closed
wants to merge 16 commits into from
Closed

nightly channels rebased #384

wants to merge 16 commits into from

Conversation

visr
Copy link
Contributor

@visr visr commented Aug 15, 2022 •
edited
Loading

Rebased version of #197 from @simeonschaub.
As mentioned in #197 (comment) I thought the rebase was quite tricky, so please have a good look.

> juliaup add 1.6
Installing Julia 1.6.7+0.x64 (x64).
> juliaup add 1.7
Installing Julia 1.7.3+0.x64 (x64).
> juliaup add 1.8
Installing Julia 1.8.2+0.x64 (x64).
> juliaup add nightly
Installing Julia 1.9.0-latest+0.x64 (x64).

simeonschaub and others added 12 commits August 15, 2022 22:17
@simeonschaub @visr
support nightly channels
c36986f 
The way this works is that we mark which versions are nightly versions
in the versions db during the build process and then special-case those
when added as a channel or when updated. Right now, `juliaup update`
will always download new nightly tarballs, which could potentially be
wasteful if that's called again in quick succession, but I think for now
that should be a reasonable solution.

I have also gotten rid of a lot of code duplication in `build.rs`, which
should make adding new platforms easier in the future. I hope I didn't
miss anything there.

Closes JuliaLang#96
@davidanthoff @visr
Remove unnecessary code
ccfbefb
@simeonschaub @visr
fix
1b9e8dd
@visr
remove unused functions
bc36695
@visr
add GlobalPaths argument to install_version
0c6ddc8
@visr
no mac aarch64 1.7.3 build
1389a52
@visr
restore build.rs from before latest rebase
8c34763
@visr
Make aarch64 default on Mac starting with 1.8.0-rc3
5cbd69d 
From ab6c645
@visr
Use valid semver identifiers for available_versions
a59e5c8 
From commit e3839d2
@davidanthoff @visr
Add Julia 1.6.7
e18941f 
(cherry picked from commit 475534b)
@davidanthoff @visr
Add minor channels for prerelease
393b41e 
(cherry picked from commit 12c85d5)
@davidanthoff @visr
Add Julia 1.8.0-rc4
1154c74 
(cherry picked from commit b23cedc)
@visr visr mentioned this pull request Aug 15, 2022
Closed
@vchuravy
Copy link
Member

Can we make the version for nightly something like 1.9.0-DEV.1130 That's what Julia will report.

@vchuravy vchuravy requested a review from davidanthoff August 16, 2022 01:23
@inkydragon
Copy link
Member

Maybe we can use the commit hash in the filename: ec98087cbf. That is also useful.

<Contents>
  <Key>assert_bin/freebsd/x64/1.9/julia-ec98087cbf-freebsd64.tar.gz.asc</Key>
  <LastModified>2022-08-16T08:09:07.000Z</LastModified>
  <ETag>&quot;593344e3fd43657978d35aae529226ec&quot;</ETag>
  <Size>866</Size>
  <StorageClass>STANDARD</StorageClass>
</Contents>

Otherwise, you may need to call Julia to get the version number.

$ julia-latest --version
julia version 1.9.0-DEV
$ julia-latest -e 'println(VERSION)'
1.9.0-DEV.1132

@visr
Copy link
Contributor Author

visr commented Aug 24, 2022 •
edited
Loading

Hmm I don't really understand this anymore, perhaps something went wrong trying to keep this up to date. I don't know if others see the same on this brach, but juliaup list now shows me:

 1                 1.7.3+0~x64
 beta              1.8.0-rc3+0~x64
 lts               1.6.6+0~x64
 rc                1.8.0-rc3+0~x64
 release           1.7.3+0~x64
 nightly           1.9.0-latest+0~x64

Despite the latest 1.8 being there in https://github.com/visr/juliaup/blob/night/build.rs#L25.

EDIT: nevermind, I just built the wrong version, now I get the corrent list:

 1                 1.8.2+0.x64
 beta              1.8.2+0.x64
 lts               1.6.7+0.x64
 nightly           1.9.0-latest+0.x64
 rc                1.8.2+0.x64
 release           1.8.2+0.x64

@zsz00
Copy link

zsz00 commented Sep 13, 2022

What is the current state of this?

@Krastanov Krastanov mentioned this pull request Sep 24, 2022
Closed
@visr
Copy link
Contributor Author

visr commented Oct 7, 2022

What is the current state of this?

Just brought this back up to date with main. Would now be a good time to get this functionality in @davidanthoff?

@Azzaare
Copy link

Azzaare commented Nov 16, 2022

Sorry to bump this post when you all are probably busy.

Although it is not an emergency, the nightly channel would be a very nice feature for one of my project. Hope it will be merge soon!

@pepijndevos pepijndevos mentioned this pull request Nov 23, 2022
Closed
@simsurace
Copy link
Contributor

@davidanthoff, this PR would be really handy. Do you think it could be merged before the new year (to set an arbitrary target)?

@visr
Copy link
Contributor Author

visr commented Dec 28, 2022

I think this PR and #197 are not going to get merged and can probably be closed. The issue to follow is #96.

@visr visr closed this Dec 28, 2022
@visr visr mentioned this pull request Dec 28, 2022
Closed
@visr visr deleted the night branch February 12, 2024 13:53
@MilesCranmer
Copy link
Member

MilesCranmer commented Feb 17, 2024 •
edited
Loading

This is the first hit on Google so just wanted to link the PR that has now added nightly: #809 (and been merged! Just update juliaup.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidanthoff davidanthoff Awaiting requested review from davidanthoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@visr @vchuravy @inkydragon @zsz00 @Azzaare @simsurace @MilesCranmer @simeonschaub @davidanthoff