Use system certificates on Linux #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I am fine with having |
|
We've had enough agreement over at #363 that I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363.
This does NOT implement a special case for Debian based distributions. I looked into doing that, but it was way more involved than I thought it would be and I think the likelihood that I would make some mistake in trying to implement that is too high. The problem is that
ureqhas a conditional compile to either use the Mozilla list or the system cert list, but one can't have both easily. So I would have to vendor code from ureq in this crate here, and then we would need to make sure we track changes to that upstream, and especially with security sensitive stuff that seems like a really bad idea to me.So, the main question is: are we ok to use the system cert list on Linux always, even on Linux? I think Julia is doing the same in the package manager, so maybe this is just all ok?
@StefanKarpinski, I'll defer to you to make a call on this one.