Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated.jl #9820

Closed
wants to merge 1 commit into from
Closed

Update deprecated.jl #9820

wants to merge 1 commit into from

Conversation

matrixmorpheus
Copy link
Contributor

Some rules can be bent. #9803

Others can be broken. #9779

andreasnoack
andreasnoack reviewed Jan 17, 2015
View reviewed changes
base/deprecated.jl
@@ -273,3 +273,12 @@ const base64 = base64encode

@deprecate error(ex::Exception) throw(ex)
@deprecate error{E<:Exception}(::Type{E}) throw(E())

@deprecate CholmodSparse!(colpt, rowval, nzval, m) CholmodSparse(colpt, rowval, nzval, m)
@ddprecate lufact!(S::SparseMatrixCSC) lufact(S)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in @ddprecate.

@andreasnoack
Copy link
Member

Thanks for doing this.

@ViralBShah
Copy link
Member

Love the matrix quotes!

@ViralBShah ViralBShah added the sparse Sparse arrays label Jan 17, 2015
@matrixmorpheus
Update deprecated.jl
32c4368 
Some rules can be bent. JuliaLang#9803

Others can be broken. JuliaLang#9779
@jiahao
Copy link
Member

jiahao commented Jan 18, 2015

It looks like the @deprecate macro cannot handle unexported symbols. See error in log:

invalid usage of @deprecate

Offending line:

 @deprecate Triangular{T,S,:U,true} Base.LinAlg.UnitUpperTriangular

@jiahao jiahao mentioned this pull request Jan 18, 2015
Closed
@andreasnoack
Copy link
Member

I've made a small change in e40c11b to avoid a vast amount of ambiguities on packages. Hence TriangularUnion should be AbstractTriangular.

@ViralBShah ViralBShah added the linear algebra Linear algebra label Jan 19, 2015
@ivarne
Copy link
Member

ivarne commented Jan 22, 2015

It's kind of sad to not have deprecations when we change something. What should we do?

@jiahao
Copy link
Member

jiahao commented Jan 31, 2015

bump

@andreasnoack
Copy link
Member

Isn't this one depending on #9830?

@jiahao
Copy link
Member

jiahao commented Jan 31, 2015

Oh, right.

@ViralBShah
Copy link
Member

Bump. What do we do here now, with the recent update to Cholmod?

@jiahao
Copy link
Member

jiahao commented Feb 15, 2015

This PR needs to be redone and we still need #9830 to create a proper deprecation.

@ViralBShah
Copy link
Member

I am not sure that the deprecated lufact!(s::SparseMatrixCSC) should call lufact - although there is no harm in doing so. My guess is that due to its buggy nature, it would not have been used much at all. CholmodSparse is/was an internal API, and we don't need to worry about it.

Cc: @andreasnoack on what to do with the triangular stuff. Maybe best to just close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
linear algebra Linear algebra sparse Sparse arrays
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matrixmorpheus @andreasnoack @ViralBShah @jiahao @ivarne @jakebolewski