Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added factorial example to examples #9667

Closed
wants to merge 3 commits into from

Conversation

melvin0008
Copy link

No description provided.

@ViralBShah
Copy link
Member

Could you say a little bit about the motivation for this? In general, the examples directory is not well motivated or used - and I would really just like to remove it.

@melvin0008
Copy link
Author

I was looking for open source projects to contribute to and I really loved Julia. So I thought of contributing to the examples as a starter. So its not really something huge. You can go ahead and delete it.

Btw please checkk this repo I started.
Thinking of listing everything about julia.
https://github.com/melvin0008/awesome-julia

@ViralBShah
Copy link
Member

Welcome to Julia. Please don't get me wrong. I meant delete the entire examples directory - not just your contribution. It currently is just a random set of things that accumulated over the years.

The awesome-julia stuff is neat! It would be great if you could submit a PR to the julia website to link it on our learning page, right below Julia.jl there.
http://julialang.org/learning/

@ViralBShah ViralBShah closed this Jan 8, 2015
@ViralBShah
Copy link
Member

BTW, one great way to start contributing is by adding tests. We need many more tests.

Please see #9493 to get started.

@melvin0008
Copy link
Author

Sure I get it 👍

@StefanKarpinski
Copy link
Member

The trouble with the examples directory is that they get pretty stale if they're not tested, so they tend to be of negative value – after a while, they're actively misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants