Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is more careful in gc_mark_task given that part of the jl_root_task stack may not have been moved (also don't bother copying some of the top of it)
with the recent changes to julia_init, this scenario was possible, if julia_init was called from a lower stack frame then any call to
jl_apply
. this only applied to embedded context, since this doesn't happen forrepl.c
. however, since it can handle it, i also make use of this to skip copying the first 1024 bytes of the root task.@JeffBezanson done as a PR so you can check that my
>=
conditions are correct (with the assumption that the stack grows down)