Name atan2 arguments consistently #8940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing `methods(atan2)` reveals an inconsistency in the names of the arguments x and y. The documentation about atan2 says `atan2(y, x)`, but the names in the functions are inverted.
ivarne
added a commit
that referenced
this pull request
Nov 8, 2014
Name atan2 arguments consistently
|
Looks good! Thanks. I'll backport this to the |
|
Thanks! This is why it is great to have a public TODO list. I didn't think it was that long since last time I went through the list. |
|
no, it wasn't, but see issue 9045 - getting close to stable bugfix release time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing
methods(atan2)reveals an inconsistency in the names of the arguments x and y. The documentation about atan2 saysatan2(y, x), but the names in the functions are inverted.