Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have Pkg check that the Git version is 1.7.3+ #8889

Merged
merged 1 commit into from
Nov 21, 2014
Merged

Have Pkg check that the Git version is 1.7.3+ #8889

merged 1 commit into from
Nov 21, 2014
+17 −2

Conversation

jakebolewski
Copy link
Member

See #8887

@StefanKarpinski
Copy link
Member

Looks good to me.

@ivarne
Copy link
Member

ivarne commented Nov 3, 2014

+1000 and @JuliaBackports

Now that we have decided on a known version to require, it would be good to update the README with the version requirement on git.

@staticfloat
Copy link
Member

Thanks Jake. See also #8771

@nolta
Copy link
Member

nolta commented Nov 3, 2014

Needs a squash.

@jakebolewski jakebolewski force-pushed the jcb/check_git_version branch from 6d6fdd9 to 9c95976 Compare November 3, 2014 20:12
@jakebolewski
Copy link
Member Author

I don't know why the pkg test is failing on Travis. The OSX travis build looks broken today.

@staticfloat
Copy link
Member

gcc 4.9.2 was just released, so all of the paths built into bottles are screwed up.

@jakebolewski jakebolewski force-pushed the jcb/check_git_version branch 2 times, most recently from 1c238cd to e4190d2 Compare November 21, 2014 05:23
@jakebolewski jakebolewski mentioned this pull request Nov 21, 2014
Closed
@staticfloat
Copy link
Member

git has funny version numbers. It has version numbers like 1.8.5.5, which aren't valid semvers. I have some code to kinda-sorta take care of things like this in Homebrew.jl, that you are welcome to pilfer.

jakebolewski added a commit that referenced this pull request Nov 21, 2014
@jakebolewski
Merge pull request #8889 from JuliaLang/jcb/check_git_version
3a74065 
Have Pkg check that the Git version is 1.7.3+
@jakebolewski jakebolewski merged commit 3a74065 into master Nov 21, 2014
@tkelman
Copy link
Contributor

tkelman commented Nov 22, 2014

@jakebolewski can you recall the root cause of the ERROR: unlink: no such file or directory (ENOENT) that you had been seeing on Travis here? It's happening on release-0.3 now that this was prematurely backported.

ivarne added a commit that referenced this pull request Nov 22, 2014
@ivarne
Fix another issue with the backport of #8889
83f8018
@jakebolewski jakebolewski mentioned this pull request Dec 2, 2014
Closed
@jiahao jiahao deleted the jcb/check_git_version branch January 18, 2015 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jakebolewski @StefanKarpinski @ivarne @staticfloat @nolta @tkelman