Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests for various reflection functions #8251

Merged
merged 3 commits into from
Sep 7, 2014
Merged

Add some tests for various reflection functions #8251

merged 3 commits into from
Sep 7, 2014

Conversation

danluu
Copy link
Contributor

@danluu danluu commented Sep 6, 2014

Added a few tests to prevent a regression like the one fixed by #8239. Also added a couple other tests while I was looking at reflection.jl.

JeffBezanson added a commit that referenced this pull request Sep 7, 2014
Add some tests for various reflection functions
@JeffBezanson JeffBezanson merged commit 30c4160 into JuliaLang:master Sep 7, 2014
@JeffBezanson
Copy link
Member

More tests are always appreciated!

@tkelman
Copy link
Contributor

tkelman commented Sep 8, 2014

Something's wrong with the redirection of stdout / stderr here. The "From worker N:" output is missing on every later test that runs on the same worker as test/reflection.jl

@danluu
Copy link
Contributor Author

danluu commented Sep 8, 2014

@tkelman Argh! Good catch. I think I see what happened and I'll submit a fix for it after I can verify it. If that's not it, I'll just remove the functions that print to stdout for now and the redirection and figure it out later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants