RFC: add a warning against having multiple copies of a shared library loaded #7490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed at the same time. this is useful because it is undefined which library C may use to lookup various functions. this can be problematic if there is global state in the shared library which is expected to be common across calls to the library from various dependencies
|
I think (due to my own experiences) a warning is exactly what is needed. In the best case, not only the event (multiple libraries) should be reported, but also the place in the program where this was asked for (something like a backtrace?). |
|
+1 I was just bitten by this as I was getting weird behavior due to tortoise git's libgit dll being loaded over the bin deps dll I thought was being used. |
jiahao
force-pushed
the
master
branch
3 times, most recently
from
6c7c7e3 to
1a4c02f
Compare
|
er, I guess not, since we haven't done anything about this in more than 4 years |
petvana
added a commit
to petvana/julia
that referenced
this pull request
Nov 4, 2021
…ies of the same shared library
petvana
added a commit
to petvana/julia
that referenced
this pull request
Nov 4, 2021
…pies of the same shared library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the first part in a series of improvements I would like to make to improve dealing with binary dependency (and inspired by JuliaCon!)
this might be useful because it is undefined which library C may use to lookup various functions. this can be problematic if there is global state in the shared library which is expected to be common across calls to the library from various dependencies
this behavior should probably also be part of
get_libraryinccall.cppto be truly usefulthe main open question is whether this should only warn about explicitly loaded dependencies, or all (as it does now, and is, I think, preferable)