Fix #6262 #6266
Merged
Fix #6262 #6266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| ifelse(stop < start, 0, | ||
| checked_add(checked_sub(convert(Int,stop),convert(Int,start)),1)), | ||
| 0) # hack to elide negative length check | ||
| eval(:(typealias SmallInteger Union(Int8,Int16,Int32,Uint8,Uint16))) |
There was a problem hiding this comment.
I don't think the eval is necessary.
There was a problem hiding this comment.
You are correct. I didn't internalize that the body of an if statement is still top-level scope.
|
Should I merge this, or is the rangepocalypse nigh? |
|
Not sure. I guess this is safe enough that you should just merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an Int for the accumulation variable when iterating over integer types smaller than Int, and the type of the range when iterating over types larger than Int