Use single call to dsfmt_gv_genrand_uint32() for small ranges (Take 2) #5741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5549 and is an extended version of #5578 to accommodate for future changes to Range1, see #5585
*
As known, tests in test/linalg.jl are sensitive to changes in the RNG and will break, see Saner error bounds on linear algebra tests LinearAlgebra.jl#67Fixed by A more robust error bound for the determinant. #5902 !last()-first()+1 == 0
and are handled correctly by using a variant ofrem
This is tricky to test (e.g. it is not possible to check if rand(1:2^50) covers the full range or is exactly uniform...) so please have a close look for one-off-errors and ideas for good tests are welcome.