Change memory indexing to use the type as index instead of i8 #57389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for my reference, what are nsw and nuw? |
|
“No Unsigned Wrap” and “No Signed Wrap” |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
|
Well good news bad news. lots of massive improvements, but an almost equal number of very real regressions. |
…dd nsw/nuw flags whenever possible.
gbaraldi
force-pushed
the
gb/memory-fun
branch
from
8ed5c35 to
2ec52b4
Compare
oscardssmith
removed
the
merge me
vtjnash
referenced
this pull request
Feb 21, 2025
…57471) The buffer may end up reallocated by the additional writes performed to it in this function.
KristofferC
pushed a commit
that referenced
this pull request
Feb 21, 2025
also add nsw/nuw flags whenever possible. (cherry picked from commit b9a8d46)
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Feb 24, 2025
…ad of i8 (JuliaLang#57389)" This reverts commit b9a8d46.
Zentrik
added a commit
to Zentrik/julia
that referenced
this pull request
Feb 24, 2025
…ex instead of i8 (JuliaLang#57389)"" This reverts commit 8e4e86d.
giordano
pushed a commit
to Zentrik/julia
that referenced
this pull request
Feb 25, 2025
…ad of i8 (JuliaLang#57389)" This reverts commit b9a8d46.
giordano
pushed a commit
to Zentrik/julia
that referenced
this pull request
Feb 25, 2025
…ex instead of i8 (JuliaLang#57389)"" This reverts commit 8e4e86d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also add nsw/nuw flags whenever possible.