Make late_gc_lowering more robust #57380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… usage a bit more
vchuravy
reviewed
Feb 13, 2025
vtjnash
reviewed
Feb 14, 2025
Co-authored-by: Jameson Nash <[email protected]>
Zentrik
reviewed
Feb 24, 2025
| for (AllocaInst *Alloca : gc_allocas) { | ||
| llvm_dump(Alloca); | ||
| } | ||
| assert(false && "Expected single alloca"); |
There was a problem hiding this comment.
Is there a reason that this is an assert, somewhat annoying the message doesn't print on non assert builds.
There was a problem hiding this comment.
Pushed a fix to your branch :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where we optimize the SRet more than the pass expected so try and handle those. I'm tryin to get a test for this, this is separated from #52850 to make merging both easier