Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "constrain the path argument of include functions to AbstractString" #55938

Closed
wants to merge 1 commit into from
Closed

Revert "constrain the path argument of include functions to AbstractString" #55938

wants to merge 1 commit into from

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Sep 30, 2024

Reverts #55466 as it was a breaking change, and doesn't appear to be necessary

@vtjnash vtjnash requested a review from Keno September 30, 2024 14:06
@nsajko nsajko added the revert This reverts a previously merged PR. label Sep 30, 2024
@nsajko
Copy link
Contributor

nsajko commented Sep 30, 2024

If this revert happens, should the ::AbstractString constraints be removed from the doc strings?

@nsajko nsajko added the modules label Sep 30, 2024
@vtjnash vtjnash closed this Nov 7, 2024
@vtjnash vtjnash deleted the revert-55466-module_include_constraint_path_arg_to_abstractstring branch November 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Awaiting requested review from Keno

Assignees
No one assigned
Labels
modules revert This reverts a previously merged PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtjnash @nsajko