Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dispatch for rdiv! with LU #55764

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Fix dispatch for rdiv! with LU #55764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7395f0c
Fix dispatch for `rdiv!` with `LU`
dkarrasch Sep 13, 2024
a77a966
avoid double tri-wrapper
dkarrasch Sep 13, 2024
b89aeb6
bring back rdiv! method, but restrict to Tridiagonal
dkarrasch Oct 26, 2024
1c4de6b
Merge branch 'master' into dk/rdiv_lu
dkarrasch Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/LinearAlgebra/src/lu.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ function ldiv!(adjA::AdjointFactorization{<:Any,<:LU{T,Tridiagonal{T,V}}}, B::Ab
return B
end

rdiv!(B::AbstractMatrix, A::LU) = transpose(ldiv!(transpose(A), transpose(B)))
rdiv!(B::AbstractMatrix, A::LU{T,Tridiagonal{T,V}}) where {T,V} = transpose(ldiv!(transpose(A), transpose(B)))

# Conversions
AbstractMatrix(F::LU) = (F.L * F.U)[invperm(F.p),:]
Expand Down
16 changes: 8 additions & 8 deletions stdlib/LinearAlgebra/src/triangular.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,16 +1048,16 @@ _trimul!(C::AbstractMatrix, A::AbstractTriangular, B::UpperOrLowerTriangular) =

function lmul!(A::AbstractTriangular, B::AbstractVecOrMat)
if istriu(A)
_trimul!(B, UpperTriangular(A), B)
_trimul!(B, uppertriangular(A), B)
else
_trimul!(B, LowerTriangular(A), B)
_trimul!(B, lowertriangular(A), B)
end
end
function rmul!(A::AbstractMatrix, B::AbstractTriangular)
if istriu(B)
_trimul!(A, A, UpperTriangular(B))
_trimul!(A, A, uppertriangular(B))
else
_trimul!(A, A, LowerTriangular(B))
_trimul!(A, A, lowertriangular(B))
end
end

Expand Down Expand Up @@ -1097,16 +1097,16 @@ _rdiv!(C::AbstractMatrix, A::AbstractMatrix, B::UpperOrLowerTriangular) =

function ldiv!(A::AbstractTriangular, B::AbstractVecOrMat)
if istriu(A)
_ldiv!(B, UpperTriangular(A), B)
_ldiv!(B, uppertriangular(A), B)
else
_ldiv!(B, LowerTriangular(A), B)
_ldiv!(B, lowertriangular(A), B)
end
end
function rdiv!(A::AbstractMatrix, B::AbstractTriangular)
if istriu(B)
_rdiv!(A, A, UpperTriangular(B))
_rdiv!(A, A, uppertriangular(B))
else
_rdiv!(A, A, LowerTriangular(B))
_rdiv!(A, A, lowertriangular(B))
end
end

Expand Down