Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL.prompt!: use lower level than peek to wait on input #54854

Closed
wants to merge 4 commits into from

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Jun 20, 2024

Response to #54785 (comment)

I've not been able to reproduce the IOBuffer not marked issue so I'm at the mercy of others testing this.

Requires

@IanButterworth IanButterworth added REPL Julia's REPL (Read Eval Print Loop) backport 1.11 Change should be backported to release-1.11 labels Jun 20, 2024
@IanButterworth IanButterworth requested a review from Keno June 20, 2024 01:45
@Keno
Copy link
Member

Keno commented Jun 20, 2024

I think the eof is not required anymore. Unfortunately, I don't know how to reproduce it either, I just was just hitting keys and it died at some point.

@IanButterworth
Copy link
Member Author

I think the actual fix here is to just use peek(term) rather than peek(term, Char) because the latter appears to be broken #54785 (comment) for non-ascii Chars and peek(term) seems to be the simplest public method that gives what we want (a wait for input).

@IanButterworth IanButterworth deleted the ib/repl_fix branch June 20, 2024 18:58
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants