Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some more deepcopy_internal methods type stable #54562

Merged
merged 2 commits into from
May 23, 2024

Conversation

lgoettgens
Copy link
Contributor

Same as #54496 for some more methods.
I added some more testcases than the changed methods. For SimpleVector, I don't know how to construct an instance for a testcase.

This could be backported to 1.11.

@LilithHafner LilithHafner added merge me PR is reviewed. Merge when all tests are passing backport 1.11 Change should be backported to release-1.11 labels May 23, 2024
Copy link
Member

@LilithHafner LilithHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fingolfin fingolfin merged commit 7273b9a into JuliaLang:master May 23, 2024
8 of 9 checks passed
@lgoettgens lgoettgens deleted the lg/deepcopy-typestable branch May 24, 2024 06:45
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label May 24, 2024
KristofferC pushed a commit that referenced this pull request May 27, 2024
Same as #54496 for some more
methods.
I added some more testcases than the changed methods. For
`SimpleVector`, I don't know how to construct an instance for a
testcase.

This could be backported to 1.11.

(cherry picked from commit 7273b9a)
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label May 28, 2024
lazarusA pushed a commit to lazarusA/julia that referenced this pull request Jul 12, 2024
Same as JuliaLang#54496 for some more
methods.
I added some more testcases than the changed methods. For
`SimpleVector`, I don't know how to construct an instance for a
testcase.

This could be backported to 1.11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants