Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash in "Official https://julialang.org/ release" #53978

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

LilithHafner
Copy link
Member

The url in the "official release" note ends in a trailing slash and is a plausible typo for https://julialang.org/release (for a moment I thought this was the case). I propose removing the trailing slash to reduce potential confusion there, and to be consistent with the documentation url, and because in a browser, https://julialang.org/ redirects to https://julialang.org.

Current:

x@fedora:~/.julia/dev/julia$ julia
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.11.0-alpha2 (2024-03-18)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> 
x@fedora:~/.julia/dev/julia$ julia --banner=short
  o  | Version 1.11.0-alpha2 (2024-03-18)
 o o | Official https://julialang.org/ release
julia> 

Proposed:

x@fedora:~/.julia/dev/julia$ julia
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.11.0-alpha2 (2024-03-18)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org release
|__/                   |

julia> 
x@fedora:~/.julia/dev/julia$ julia --banner=short
  o  | Version 1.11.0-alpha2 (2024-03-18)
 o o | Official https://julialang.org release
julia> 

@LilithHafner LilithHafner requested a review from tecosaur April 6, 2024 17:08
@LilithHafner LilithHafner merged commit c5a3b65 into master Apr 7, 2024
4 of 7 checks passed
@LilithHafner LilithHafner deleted the lh/banner-url branch April 7, 2024 16:36
@fredrikekre
Copy link
Member

Did you change the source of this string too? This PR just changes the output. Also breaks https://github.com/JuliaLang/PackageCompiler.jl/blob/8e579083b1142dab26f268d77650e680cad6b4b5/src/PackageCompiler.jl#L743 so that needs some adjustments.

@LilithHafner
Copy link
Member Author

Oh, strange. The source is not anywhere in the source tree of Julia.

shell> ag "Official"
doc/src/devdocs/probes.md
191: _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org release
267: _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org release

stdlib/InteractiveUtils/src/InteractiveUtils.jl
107:    official_release = Base.TAGGED_RELEASE_BANNER == "Official https://julialang.org release"

stdlib/TOML/benchmark/files/Registry.toml
6:Official general Julia package registry where people can

CITATION.cff
1:# Official format description at https://citation-file-format.github.io

@DilumAluthge
Copy link
Member

https://github.com/search?q=repo%3AJuliaCI%2Fjulia-buildkite%20official&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants