add initial support for OpenBSD #53633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- libsuitesparse: use $(MAKE) instead of hardcoding "make" (it is "gmake" on BSD) - patchelf: pass MAKE variable - libssh2: pass -fPIC if need (permit libgit2 to link on OpenBSD)
- libgit2: search iconv.h in right directory - pcre2: avoid RWX memory by disabling jit on OpenBSD - libssh2 - libsuitesparse - mbedtls
Keno
reviewed
Mar 8, 2024
Keno
reviewed
Mar 8, 2024
Keno
reviewed
Mar 8, 2024
fingolfin
reviewed
Mar 8, 2024
Co-authored-by: Max Horn <[email protected]>
|
there is something I should do to make progress here ? |
oscardssmith
added
the
building
oscardssmith
approved these changes
Mar 25, 2024
|
No. I think this looks ready to merge. |
fingolfin
approved these changes
Mar 25, 2024
|
Do we have any prospect for CI for OpenBSD? |
|
|
Do you want any of the commit messages to be retained in the squash merge description here? Github's default squash merge message is just the original PR post, so if you do perhaps elaborate there? |
Buildkite provides official OpenBSD binaries for the agent with every release. Like Windows, our FreeBSD CI is set up to run under KVM on Linux, so we could theoretically make an analogous setup for OpenBSD. |
|
@IanButterworth I am fine with default squash merge. I did several differents commits to help reviewing (and not mix too many things) |
IanButterworth
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits add initial support of OpenBSD in julia.
It isn't strictly enough to make julia runable on OpenBSD (see #53632), but it covers the larger part.