-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ScopedValues for TestSets #53462
base: master
Are you sure you want to change the base?
Conversation
1c67443
to
b1fec32
Compare
@vchuravy @Keno I'm getting some weird failures on this branch originating from this line: julia/base/compiler/ssair/passes.jl Line 1162 in c379db7
The simplest reproducer I have is: using Test
@testset begin
@testset for r in Int[1]
end
end |
Blocked by #53521 |
73b39d1
to
0cd361c
Compare
0cd361c
to
7ef5878
Compare
Would love to see this merged! @simonbyrne do you have any time to work on this? I'd be happy to rebase and help get it over the line. I think rebasing, and then deciding what to do with the commented-out scope tests might be all that's needed here? |
I initially thought I managed to badly botch the rebase, but I believe this is now failing to build because after the rebase #55452 was merged in and that PR removed |
Sorry, it still needs some work. The handling of errors is wasn't quite correct, and the resetting of rng state is kind of confusing (arguably should be handled differently) |
Currently blocked by #56062 |
Another attempt at #51012