Fix inconsistency between exct and nothrow effect #52853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
added
bugfix
aviatesk
reviewed
Jan 11, 2024
Comment on lines
+3298
to
+3302
| if exct !== Union{} | ||
| update_exc_bestguess!(interp, exct, frame) | ||
| # TODO: assert that these conditions match. For now, we assume the `nothrow` flag | ||
| # to be correct, but allow the exct to be an over-approximation. | ||
| end |
There was a problem hiding this comment.
In the future, I think the exct modeling should encompass the nothrow modeling. But I agree with you that this approach might be the best for now. We'd seize opportunities to enhance exct modeling as they arise.
There was a problem hiding this comment.
Yes, we should eventually delete the nothrow effect in favor of this, but I don't think there's any urgency.
Fixes #52846. Different unreachability checks use different definitions for this and were inconsistenct, causing the assertion. Since the exct modeling isn't fully plubmed through all corners of the compiler yet, also change the caller code to force the nothrow effect to be authoritative for the time being.
aviatesk
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52846. Different unreachability checks use different definitions for this and were inconsistenct, causing the assertion.
Since the exct modeling isn't fully plubmed through all corners of the compiler yet, also change the caller code to force the nothrow effect to be authoritative for the time being.