Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing docstrings for Base.Sys #52777
add missing docstrings for Base.Sys #52777
Changes from 4 commits
424998b
7fa4956
1205874
d70aa64
2e70a60
321f497
28df075
4e20ecc
aab0507
f1a6291
e84a16a
2096423
3e63af5
3f38416
0a3cf6f
e11dfd9
eaf73a8
3f6bec7
88e6fae
f35cb86
a41c271
526ac1e
60fdb2f
fc3d652
4b3722a
8f84372
8d92a49
143169d
3309d86
5e2cdbd
06f5a4c
6cf7d26
718740e
adbf6b0
a391a4e
d4e3a3d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented earlier, if we are going to mention the
CPUinfo
type in the docstrings, then it becomes part of the public API, and there should at least be apublic CPUinfo
statement reflecting this, as well as moving this information about the
struct
into a docstring forCPUinfo
(which then also goes in the manual).