Added source-dist makefile target

[ivarne]

This is an alternative to #5264 @staticfloat

This approach has less hardcoded paths and does not make a copy before compressing.

[ivarne]

oops.. It seems like I did not include tar.bz files

[staticfloat]

This approach looks generally better than mine; I thought about using git to get the list of files but decided not to so I could omit files such as .travis.yml, etc... which don't really need to be included. In the end though, this approach is much simpler and including those files doesn't matter at all. :)

[staticfloat]

I'll test on OSX in the next day or so.

[ivarne]

Now it does not download anything when try make -C deps getall, but I still have not tested this enough.

[staticfloat]

sed -i".bak" creates source-dist.tmp.bak which you need to clean up as well.

[ivarne]

I noticed, but wanted to push the other updates before going to sleep.

[staticfloat]

For some reason, tar is still including the .git directories for the submodules:

$ tar -tvf ./julia-0.3.0-prerelease_cad6390270.tar.gz  | grep "\.git"
-rw-r--r--  0 sabae  staff      38 Oct 25 20:59 deps/Rmath/.git
-rw-r--r--  0 sabae  staff     139 Oct 25 20:59 deps/Rmath/.gitignore
-rw-r--r--  0 sabae  staff      17 Oct 25 20:59 deps/Rmath/src/.gitignore
-rw-r--r--  0 sabae  staff      38 Oct 25 20:59 deps/libuv/.git
-rw-r--r--  0 sabae  staff     523 Oct 25 20:59 deps/libuv/.gitignore
-rw-r--r--  0 sabae  staff       7 Oct 25 20:59 deps/libuv/src/.gitignore
-rw-r--r--  0 sabae  staff       7 Oct 25 20:59 deps/libuv/src/win/.gitignore
-rw-r--r--  0 sabae  staff      41 Oct 25 20:59 deps/openlibm/.git
-rw-r--r--  0 sabae  staff      30 Oct 25 20:59 deps/openlibm/.gitignore
-rw-r--r--  0 sabae  staff     106 Oct 25 20:59 deps/openlibm/test/.gitignore
-rw-r--r--  0 sabae  staff      44 Dec 27 16:50 deps/openspecfun/.git
-rw-r--r--  0 sabae  staff     144 Dec 27 16:50 deps/openspecfun/.gitignore
-rw-r--r--  0 sabae  staff      40 Oct 25 20:59 doc/juliadoc/.git
-rw-r--r--  0 sabae  staff     303 Oct 25 20:59 doc/juliadoc/.gitignore

[ivarne]

Do you think the naming of the tarball is fine? Users who doesn't use tab completion (scripts?) will have problem typing 10 characters of the sha.

I would also like to have the tarball extract to a folder, but have not figured out how to do that when giving a file list with -T.

[staticfloat]

I think it's pretty standard to have the tarball not extract to a subdirectory, especially when dealing with source packages. Similarly, the name is fine I think. I think the biggest user of source-dist is going to be distributors and packagers, and dealing with long filenames is not an issue. make source-dist is probably going to be run by scripts more often than it's going to be run manually.

[ivarne]

The problem is that ls-files lists the directories for submodules. Adding --no-recursion to the tar command is the simplest fix.

[ivarne]

I would want to update DISTRIBUTING.md also, but that will conflict with #5095

[staticfloat]

Hmmm, it seems that you need to special-case in the deps/readline62-00X files. Perhaps a better solution is to just include those in our git repo? I'm not sure why those are downloaded from ftp.gnu.org instead of being saved in our git repo.

[staticfloat]

The good news is that with those files included, the generated .tar.gz builds cleanly and passes all tests!

[staticfloat]

I would want to update DISTRIBUTING.md also, but that will conflict with #5095

That PR is going to need a rebase anyway, now that we've messed around with base/version.jl, so go ahead and make your changes here.

[ivarne]

Good point, the two PRs depend on each other anyway, so I might submit a new PR that does both.

[ivarne]

Obsoleted by #5528