sroa: Better walk for chained KeyValue #52542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This redoes #52369, to put the walk through tothe chained KeyValue into a more logical place (the definition walking). This way, we automatically inherit correct handling of PhiNodes and ifelse.
Keno
changed the title
Keno
added a commit
that referenced
this pull request
Dec 21, 2023
Fixes some mistakes in #52542 that led to the following issue: ``` function persistent_dict_elim_multiple_phi2(c::Bool) z = Base.inferencebarrier(1)::Int if c a = Base.PersistentDict(:a => z) else a = Base.PersistentDict(:a => z) end b = Base.PersistentDict(a, :b => 2) return b[:a] end julia> persistent_dict_elim_multiple_phi2(true) ERROR: KeyError: key :a not found Stacktrace: [1] getindex @ Base ./dict.jl:1010 [inlined] [2] persistent_dict_elim_multiple_phi2(c::Bool) @ Main ./REPL[1]:9 [3] top-level scope @ REPL[3]:1 ``` i.e. sroa incorrectly thought the value was not found.
Keno
added a commit
that referenced
this pull request
Dec 22, 2023
Fixes some mistakes in #52542 that led to the following issue: ``` function persistent_dict_elim_multiple_phi2(c::Bool) z = Base.inferencebarrier(1)::Int if c a = Base.PersistentDict(:a => z) else a = Base.PersistentDict(:a => z) end b = Base.PersistentDict(a, :b => 2) return b[:a] end julia> persistent_dict_elim_multiple_phi2(true) ERROR: KeyError: key :a not found Stacktrace: [1] getindex @ Base ./dict.jl:1010 [inlined] [2] persistent_dict_elim_multiple_phi2(c::Bool) @ Main ./REPL[1]:9 [3] top-level scope @ REPL[3]:1 ``` i.e. sroa incorrectly thought the value was not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redoes #52369, to put the walk through tothe chained KeyValue into a more logical place (the definition walking). This way, we automatically inherit correct handling of PhiNodes and ifelse.